cargo-insta: use cargo integration tests #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
reviewed
Oct 8, 2023
tamird
force-pushed
the
integration-tests
branch
3 times, most recently
from
8a141f1
to
82560bc
Compare
|
What confuses me is how the rustfmt fails to run now with these changes on 1.61. |
|
Turns out using cargo integration tests here is more complicated than I had anticipated. I'm going to do something simpler than originally intended in #410 and come back to this later. |
tamird
force-pushed
the
integration-tests
branch
from
82560bc
to
de6e3ad
Compare
This should make CI much faster.
tamird
force-pushed
the
integration-tests
branch
from
92debc2
to
11d4697
Compare
|
@mitsuhiko this is ready for another look. The first two commits are minor CI improvements. I'm not sure the last commit is a win, but I wanted to revisit this after finally understanding how these integration tests work. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mitsuhiko this should be able to land independently of #410.