Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glob! input_file on Windows #371

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Fix glob! input_file on Windows #371

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a67247
Fix glob! input_file on Windows
smonicas May 13, 2023
3908795
Handle canonicalize failure
smonicas Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ impl<'a> SnapshotAssertionContext<'a> {
.canonicalize()
.ok()
.and_then(|s| {
s.strip_prefix(self.cargo_workspace.as_path())
s.strip_prefix(self.cargo_workspace.canonicalize().unwrap())
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately canonicalize can fail quite commonly. Ideally the error here is swallowed.

.ok()
.map(|x| x.to_path_buf())
})
Expand Down