Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump channels-redis from 4.0.0 to 4.1.0 #1178

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 3, 2023

Bumps channels-redis from 4.0.0 to 4.1.0.

Changelog

Sourced from channels-redis's changelog.

4.1.0 (2023-03-28)

  • Adjusted the way Redis connections are handled:

    • Connection handling is now shared between the two, core and pub-sub, layers.

    • Both layers now ensure that connections are closed when an event loop shuts down.

      In particular, redis-py 4.x requires that connections are manually closed. In 4.0 that wasn't done by the core layer, which led to warnings for people using async_to_sync(), without closing connections when updating from 3.x.

  • Updated the minimum redis-py version to 4.5.3 because of a security release there. Note that this is not a security issue in channels-redis: installing an earlier version will still use the latest redis-py, but by bumping the dependency we make sure you'll get redis-py too, when you install the update here.

Commits
  • 8b4ed2d Bumped version and change notes for v4.1.0 release.
  • 093471f Refs #348 -- Skip PY311 tests until redis-py fixes compatibility. (#358)
  • 6124749 Updated GHA workflow action versions. (#357)
  • 4bc3154 Fix prefix default in docs (#338)
  • 62e8fe2 Refactored Redis connection utilities to share between layers. (#352)
  • 0c89a97 Assured pools are closed on loop close in core (#347)
  • dbf4f30 Update redis-py dependency to >=4.5.3.
  • 422d735 Refs #348 -- Marked problem test cases as xfail.
  • 89b29ad Pinned redis py to 4.3.5 (#349)
  • ffe3566 Clarified that README ref to Redis version is for Redis server. (#351)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies python Pull requests that update Python code labels Jul 3, 2023
@michaeljcollinsuk
Copy link
Contributor

@dependabot recreate

Bumps [channels-redis](https://github.com/django/channels_redis) from 4.0.0 to 4.1.0.
- [Changelog](https://github.com/django/channels_redis/blob/main/CHANGELOG.txt)
- [Commits](django/channels_redis@4.0.0...4.1.0)

---
updated-dependencies:
- dependency-name: channels-redis
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/channels-redis-4.1.0 branch from d729e1e to 0a9258d Compare December 5, 2023 10:41
@michaeljcollinsuk
Copy link
Contributor

@dependabot ignore this minor version

@dependabot dependabot bot closed this Jan 9, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 9, 2024

OK, I won't notify you about version 4.1.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/pip/channels-redis-4.1.0 branch January 9, 2024 10:31
@michaeljcollinsuk
Copy link
Contributor

Ignoring this version as it broke a unit test. After initial investigation was not immediately obvious why. As there has been discussion of removing django-channels. There are also reports of breaking changes in this versionhttps://github.com/django/channels_redis/issues/348.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant