Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fanout error response - error must be string for marshaling #17433

Merged
merged 1 commit into from Jun 15, 2023

Conversation

klauspost
Copy link
Contributor

@klauspost klauspost commented Jun 15, 2023

Description

Use minio/minio-go#1839

How to test this PR?

Make fanout return errors.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana changed the title Fix fanout error response fix: fanout error response Jun 15, 2023
@harshavardhana harshavardhana changed the title fix: fanout error response fix: fanout error response - error must be string for marshalling Jun 15, 2023
@harshavardhana harshavardhana changed the title fix: fanout error response - error must be string for marshalling fix: fanout error response - error must be string for marshaling Jun 15, 2023
@harshavardhana harshavardhana merged commit 4a562d6 into minio:master Jun 15, 2023
18 checks passed
@klauspost klauspost deleted the fix-fanout-error-response branch June 15, 2023 16:28
@bh4t bh4t added the bugfix label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants