Match existing format in minio-go when listing with metadata #16906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow seamless parsing when sending data to minio-go.
klauspost
force-pushed
the
match-usertags
branch
from
1a6ecc1
to
259e0a5
Compare
|
@vadmeste It doesn't match It does however require some further tweaking: minio/minio-go#1795 |
Tags would not be marshaled correctly due to xml library fork. Add small package to handle this.
klauspost
force-pushed
the
match-usertags
branch
from
0c90342
to
dcad509
Compare
|
Dropping for simpler change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow seamless parsing when sending data to minio-go.
Seems there is already unmarshal code in minio-go objects - match the format of that instead.
Regression caused by #16883 - sorry.
How to test this PR?
Must be part of
mclistings.Types of changes