New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve removeObjects api response handling #1111

Merged

harshavardhana merged 1 commit into minio:master from prakashsvmx:remove-objects-response

Mar 24, 2023

Member

prakashsvmx commented Mar 23, 2023 •

edited

Fixes #1110

Test script
The remove objects api returns 200 but response with deletion fail reasons for each object

A user with readonly policy can be used to simulate this

var s3Client = new Minio.Client({
  endPoint: 'localhost',
  accessKey: 'test-user',
  secretKey: 'minio123',
  useSSL:false,
  port:22000
})

const deleteList = [
  { name: '1.png'},
  { name: '1.png', versionId:"test-v-is"}
]

s3Client.removeObjects("test-bucket", deleteList ,(e, res) => {
  console.log("Multiple objects delete .", res)
})


          improve removeObjects api response handling

c7bbf8e

prakashsvmx requested review from kaankabalak and kannappanr

March 23, 2023 07:21

prakashsvmx self-assigned this

harshavardhana approved these changes

View reviewed changes

harshavardhana merged commit b224d74 into minio:master

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment