fix: allow port in endpoint for aws private link validation #2066
+46
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new client for an endpoint url in the form
hostname:port
makesIsAmazonPrivateLinkEndpoint
returnfalse
since the regex used to verify if that url is a valid aws private link does not match when it contains a port.I propose to perform the validation on
Hostname()
instead ofHost
to always validate agains the actualhostname
.I've added some tests to prove that it works