Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow port in endpoint for aws private link validation #2066

Merged

Conversation

MadJlzz
Copy link
Contributor

@MadJlzz MadJlzz commented Feb 17, 2025

Creating a new client for an endpoint url in the form hostname:port makes IsAmazonPrivateLinkEndpoint return false since the regex used to verify if that url is a valid aws private link does not match when it contains a port.

I propose to perform the validation on Hostname() instead of Host to always validate agains the actual hostname.

I've added some tests to prove that it works

Verified

This commit was signed with the committer’s verified signature.
ssbarnea Sorin Sbarnea
@MadJlzz MadJlzz force-pushed the aws-privatelink-allow-ports-validation branch from 465dc37 to 9619e4f Compare February 19, 2025 08:16
@harshavardhana harshavardhana merged commit 52f0eda into minio:master Feb 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants