Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary reopening of HTTP streams in GetObject() #1908

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Avoid unnecessary reopening of HTTP streams in GetObject() #1908

merged 1 commit into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. Avoid unnecessary reopening of HTTP streams in GetObject() 

    Sometimes consumers of Seek() might use it for purposes other than
chaging the current read/write offset. For example, using whence =
io.SeekCurrent to get the current seek position. However, minio-go
invalidates the underlying HTTP stream unconditionally when Seek() is
called, resulting in massive performance degradation in these scenarios.

This commit avoids these issues by only reopening the stream if the seek
position is actually changed.
    @PeterCxy
    PeterCxy committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    a1bebf8 View commit details
    Browse the repository at this point in the history