Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws ap-southeast-4 region #1767

Merged
merged 1 commit into from Feb 8, 2023

Conversation

ianmuge
Copy link
Contributor

@ianmuge ianmuge commented Feb 6, 2023

feat: add aws ap-southeast-4 region

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianmuge
Copy link
Contributor Author

ianmuge commented Feb 7, 2023

The build seems to succeed locally but not on GA, do you mind re-running it?

@klauspost
Copy link
Contributor

Yeah, fix is in #1768

@ianmuge
Copy link
Contributor Author

ianmuge commented Feb 8, 2023

I shall just wait for the fix to be merged then, thanks

@vadmeste
Copy link
Member

vadmeste commented Feb 8, 2023

I shall just wait for the fix to be merged then, thanks

@ianmuge you can rebase your PR and push it again. The fix is just merged

@ianmuge
Copy link
Contributor Author

ianmuge commented Feb 8, 2023

ready

@klauspost klauspost merged commit 5211dc3 into minio:master Feb 8, 2023
@klauspost
Copy link
Contributor

Thanks!

@ianmuge ianmuge deleted the add-new-aws-region branch February 8, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants