Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize xml content not containing namespace #763

Merged
merged 6 commits into from
Apr 14, 2023

Conversation

martijn00
Copy link
Contributor

Followup on #762

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please notice there are 3 github actions reported for:
1- The variable 'ex' is declared but never used
2- The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
3- XML comment is not placed on a valid language element

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman ebozduman merged commit 6a45116 into minio:master Apr 14, 2023
Urantij pushed a commit to Urantij/minio-dotnet that referenced this pull request Apr 19, 2023
* Deserialize xml content not containing namespace

* Optimize

* Format

* dispose using streams

* Fixes

* addresses git actions/warnings

---------

Co-authored-by: Thomas Paterson <tpaterson@redboxvoice.com>
Co-authored-by: Ersan <ersan.bozduman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants