Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change replicate status metrics to show additional info #4582

Merged
merged 2 commits into from Aug 30, 2023
Merged

Change replicate status metrics to show additional info #4582

merged 2 commits into from Aug 30, 2023

Conversation

poornas
Copy link
Contributor

@poornas poornas commented May 26, 2023 •
edited

Description

Motivation and Context

Give additional visibility into replication status

  1. mc replicate status alias/bucket - to see current replication status since server start
  2. with --nodes flag to see current replication transfer rate by nodes in the cluster
  3. mc admin replicate status alias shows site level stats.

How to test this PR?

Needs minio/minio#17293
minio/madmin-go#196
minio/minio-go#1833

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@poornas poornas force-pushed the rmetrics2 branch 6 times, most recently from 4092c0d to 37895f0 Compare June 29, 2023 05:03
@poornas poornas force-pushed the rmetrics2 branch 2 times, most recently from 088738f to 4973e0d Compare July 22, 2023 01:20
@poornas poornas force-pushed the rmetrics2 branch 5 times, most recently from 41ceec6 to af36987 Compare August 22, 2023 02:15
shtripat
shtripat reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

cmd/replicate-status.go Outdated Show resolved Hide resolved
@poornas
Change replicate status metrics to show additional info
afde799 
in `mc replicate status` for bucket replication
and `mc admin replicate status` for site replication.
shtripat
shtripat approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 5a5a997 into minio:master Aug 30, 2023
5 checks passed
@djwfyi djwfyi mentioned this pull request Sep 5, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@shtripat shtripat shtripat approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poornas @harshavardhana @shtripat