Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme]: document string positionals #53

Merged
2 commits merged into from Mar 1, 2024

Conversation

shadowspawn
Copy link
Collaborator

Add description of disabling numeric conversion for non-option arguments. This is a stealth feature which some clients are using.

Fixes: #52

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (74f90f1) to head (5c1864e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files           1        1           
  Lines         165      165           
  Branches       70       70           
=======================================
  Hits          163      163           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as we have tests covering it

@shadowspawn
Copy link
Collaborator Author

Hmm... No test previously! There was a slightly weird existing test with string: '_' so I have added a number in there.

(Could make it a separate and more explicit numeric test if preferred.)

@shadowspawn shadowspawn force-pushed the feature/doc-string-positionals branch from 2e7c498 to 5c1864e Compare March 1, 2024 05:42
@ljharb ljharb closed this pull request by merging all changes into minimistjs:main in cfb8d4b Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document ability to disable numeric conversion for positional arguments (non-options)
4 participants