Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #44 #45

Closed
wants to merge 1 commit into from
Closed

Fixed Issue #44 #45

wants to merge 1 commit into from

Conversation

cantwellsean0127
Copy link

[v1.2.8] Set default args parameter value to process.argv.split(2)

[v1.2.8] Set default args parameter value to process.argv.split(2)
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

Merging #45 (0d3cf8e) into main (fdbb909) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files           1        1           
  Lines         165      165           
  Branches       70       71    +1     
=======================================
  Hits          163      163           
  Misses          2        2           
Files Changed Coverage Δ
index.js 98.78% <100.00%> (ø)

@shadowspawn
Copy link
Collaborator

(I started the tests, but of course they won/t show up any problems since this won't be covered by the existing tests.)

This Code does not like it will work. Have you tried it?

You can mark a Pull Request as Draft while you are still working on it and especially when not ready for review.

@cantwellsean0127 cantwellsean0127 closed this by deleting the head repository Aug 20, 2023
@ljharb
Copy link
Member

ljharb commented Aug 20, 2023

#46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants