[patch]: include aliases when looking for defaults for booleans #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 98.75% 98.78% +0.03%
==========================================
Files 1 1
Lines 161 165 +4
Branches 71 70 -1
==========================================
+ Hits 159 163 +4
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shadowspawn
changed the title
This was referenced Apr 7, 2023
ljharb
reviewed
Apr 7, 2023
|
If that refactor indeed doesn't require test changes, then at least a separate commit is good :-) whether it's a separate PR or not isn't important. |
|
Two commits now. (In the order that makes sense afterwards, rather than the order the work happened. 😆 ) |
|
(The order the work happened is always irrelevant, git has a changelog not a history :-p ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The starting values for boolean options are applied before parsing, whether
falseor a user supplied default. The check for user supplied defaults was not including aliases. Keep it simple and do in two passes using same alias detection logic as in existing code.Fixes: #29