Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin mypy type-checking #229

Merged
merged 21 commits into from
May 8, 2024
Merged

Begin mypy type-checking #229

merged 21 commits into from
May 8, 2024

Conversation

Kilo59
Copy link
Contributor

@Kilo59 Kilo59 commented Apr 26, 2024

Begin minimal type-checking of the codebase as part of the effort to export type hints.

Will followup this up to add annotations to remaining modules.

@Kilo59 Kilo59 marked this pull request as ready for review April 26, 2024 14:58
mocket/utils.py Outdated Show resolved Hide resolved
@Kilo59 Kilo59 requested a review from mindflayer May 1, 2024 16:14
pyproject.toml Outdated Show resolved Hide resolved
@mindflayer
Copy link
Owner

mindflayer commented May 8, 2024

I am sorry it took a while, I had to find some time to invest in the CI for being able to run tests on external PRs.
It looks like mypy is not happy about the way I am dealing with location when made of just a str.
I'll come back to you with a fix.

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 98.59% (-0.2%) from 98.818%
when pulling f0e5442 on Kilo59:main
into 389d95e on mindflayer:main.

@mindflayer mindflayer merged commit c434799 into mindflayer:main May 8, 2024
6 of 7 checks passed
@mindflayer
Copy link
Owner

Merged, we still lack a pre-commit hook for mypy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants