Use a lazy-quoting @sh encoder #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I also tried to figure out how to code in a quoting style switch the user could use, but I see this is not really supported for |
|
Looks great, thanks for the contribution :) |
|
It would be good to add tests for the empty quote cases you mentioned. Happy to do that myself if you don't have the time |
|
I'll do it in a couple minutes ;) |
|
Huh, it took a little more 😮💨 Crafting a yaml string starting with a single quote that's in a go string literal... It's good that I like the movie Inception 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I eventually took a hit at the second alternative from #1526 (comment), which is generally ouptut-size optimal and behaves nice for strings with a lot of safe characters.