Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using strings.Split #1501

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Avoid using strings.Split #1501

merged 2 commits into from
Nov 6, 2023

Commits on Nov 6, 2023

  1. Avoid using strings.Split 

    strings.Split has to allocate for the return slice. This allocation
was wasteful in ever case it was used in this library.

Instead we use the new strings.Cut and other string manipulation where
appropriate. This tends to lead to cleaner and more readable code in
addition to the benefits this has on the garbage collector.
    @tmthrgd
    tmthrgd committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    061340a View commit details
    Browse the repository at this point in the history

  2. Further simplify structTag in the msg_generate.go 

    This doesn't need to call strings.TrimPrefix twice.
    @tmthrgd
    tmthrgd committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f3ae4ae View commit details
    Browse the repository at this point in the history