Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer bump #1446

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Buffer bump #1446

merged 2 commits into from
Apr 27, 2023

Commits on Mar 29, 2023

  1. In func (zl *zlexer) Next() (lex, bool) 

    make max token size buffers str and com something we can grow.

Why? Because.

Reasons: When experimenting with OPENPGPKEY records, which themselves
are basically a key, if my zone file already has an RSA 4096 public key
record, this lib goes boom:

dns: bad OPENPGPKEY PublicKey: "token length insufficient for parsing" at line: .....

The key is good.

Testing against bare ed25519 keys whose base64 length is ~320 characters
and there are no problems

Testing against a bare RSA4096 key whose base64 length is ~3100 characters
and: problems.

Bare is the key word here, since for DNS, one ideally publishes as bare
a key as possible, minus signatures, minus photos, minus extra
metadata beyond the essential that will push a record length up.

A typical public key with two RSA 4K subkeys and several signatures may
rise to > ~21000 bytes.
    @systemcrash
    systemcrash committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    12e3a48 View commit details
    Browse the repository at this point in the history

  2. Test case for OPENPGPKEY (valid, test pgp public keys) 

    Reverse TLSA test record fail logic

TestNewRRCommentLengthCrasherString: ...
    @systemcrash
    systemcrash committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    79e64f1 View commit details
    Browse the repository at this point in the history