Add Deref implementation for HSTRING
#3291
Merged
+134
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build break is due to unrelated Rust nightly update - investigating. Workaround is here: #3292 |
|
Nice! |
tim-weis
reviewed
Sep 24, 2024
|
|
||
| pub fn len(&self) -> usize { | ||
| if self.0.is_null() { | ||
| fn deref(&self) -> &[u16] { |
There was a problem hiding this comment.
What's the reason for this signature rather than its more conventional spelling
fn deref(&self) -> &Self::Target?
I'm just curious if there's a particular reason.
There was a problem hiding this comment.
No reason, just seemed more succinct in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HSTRINGtype represents a UTF-16 string that is modeled as a[u16]slice in Rust. This update replaces theas_widemethod to retrieve theHSTRINGas a slice with aDerefimplementation. This makes it a lot easier to work with anHSTRINGin Rust as conversion is implicit in many cases.The same is done for
BSTRfor consistency and code reduction.Fixes: rust-lang/rustup#3896 (comment)