Set console encoding to UTF8 #4649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
force-pushed
the
set-console-encoding
branch
from
0040bee
to
72cb6a8
Compare
cvpoienaru
reviewed
Aug 10, 2023
| @@ -57,6 +57,9 @@ internal partial class FeatureFlag : IFeatureFlag | |||
| // Disable the SerialTestRunDecorator | |||
| public const string DISABLE_SERIALTESTRUN_DECORATOR = VSTEST_ + nameof(DISABLE_SERIALTESTRUN_DECORATOR); | |||
|
|
|||
| // Disable setting UTF8 encoding in console. | |||
| public const string DISABlE_UTF8_CONSOLE_ENCODING = VSTEST_ + nameof(DISABlE_UTF8_CONSOLE_ENCODING); | |||
There was a problem hiding this comment.
Any reason DISABLE has a lowercase 'l' ?
There was a problem hiding this comment.
I wish I could say I am testing your attention, but I have no idea why. My fingers must have typed it that way. I sometimes type 0 instead of o or O, and vice versa. I guess this is another quirk of l L and 1 looking the same and my brain working in visual way.
There was a problem hiding this comment.
That comment makes no sense. Probably just typed l without pressing shift, I don't have any caps lock. Fixed.
cvpoienaru
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set console encoding to UTF8.
Fix #4605