Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove process suspend #4586

Merged
merged 2 commits into from Aug 4, 2023
Merged

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jun 30, 2023

Description

Remove suspending process, because it uses undocumented NTDll on Windows.

@AbhitejJohn
Copy link
Contributor

Curious, what does removing this logic impact?

@nohwnd
Copy link
Member Author

nohwnd commented Jul 3, 2023

When you hang dump processes, we used to suspend all of them under the current testhost tree, from the bottom and then dump them, so if for some reason there are two things happening that depend on each other we get them both in the hang more reliably. If we can't use that api, then we won't suspend.

@nohwnd
Copy link
Member Author

nohwnd commented Aug 3, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd
Copy link
Member Author

nohwnd commented Aug 4, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd
Copy link
Member Author

nohwnd commented Aug 4, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd nohwnd merged commit 14a2995 into microsoft:main Aug 4, 2023
7 checks passed
@nohwnd nohwnd deleted the remove-process-suspend branch August 4, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants