Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for checking testhost compatibility with test sessions #4199

Merged
merged 2 commits into from Dec 21, 2022
Merged

Added support for checking testhost compatibility with test sessions #4199

merged 2 commits into from Dec 21, 2022

Conversation

cvpoienaru
Copy link
Member

Added support for checking testhost compatibility with test sessions

MarcoRossignoli
MarcoRossignoli reviewed Dec 14, 2022
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comment

src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/TestEngine.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/TestSession/ProxyTestSessionManager.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs Outdated Show resolved Hide resolved
Evangelink
Evangelink reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for the added branches?

@cvpoienaru
Copy link
Member Author

Could you add tests for the added branches?

Done, thanks !

@MarcoRossignoli MarcoRossignoli merged commit 992a7c4 into microsoft:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

@nohwnd nohwnd Awaiting requested review from nohwnd nohwnd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cvpoienaru @MarcoRossignoli @Evangelink