Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg_find_acquire_program(NASM).cmake] Update to version 2.16.03 #42432

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[vcpkg_find_acquire_program(NASM).cmake] Update to version 2.16.03 #42432

merged 1 commit into from
Dec 4, 2024
+2 −3

Conversation

creeksuen
Copy link
Contributor

@creeksuen creeksuen commented Nov 29, 2024 •
edited
Loading

On my individual machine, version 2.16.01 of NASM encounters the following error:

crypto\modes\aes-gcm-avx512.asm:126983: error: expecting ] at end of memory operand
NMAKE : fatal error U1077: ��"D:\workspace\ServerEngine\dependencies\vcpkg\downloads\tools\nasm\nasm-2.16.01\nasm.exe"  -Ox -f win64 -DNEAR -g -o crypto\modes\libcrypto-shlib-aes-gcm-avx512.obj "crypto\modes\aes-gcm-avx512.asm"��: ���ش��롰0x1��
Stop.
NMAKE : fatal error U1077: ��"D:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\bin\Hostx64\x64\nmake.exe" /LU                 _build_libs��: ���ش��롰0x2��
Stop.

@Cheney-W Cheney-W added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Dec 2, 2024
Cheney-W
Cheney-W previously approved these changes Dec 2, 2024
View reviewed changes
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Dec 2, 2024
@xavier2k6
Copy link
Contributor

xavier2k6 commented Dec 2, 2024 •
edited
Loading

Mirror -> https://gstreamer.freedesktop.org/src/mirror/ DOES NOT have 2.16.03 nor is there an asset for 2.16.03 via https://vcpkg.github.io/assets/nasm/

vcpkg/scripts/cmake/vcpkg_find_acquire_program(NASM).cmake

Lines 8 to 9 in d2b6159

"https://gstreamer.freedesktop.org/src/mirror/nasm-${program_version}-win64.zip"
"https://vcpkg.github.io/assets/nasm/nasm-${program_version}-win64.zip"

@Cheney-W
Copy link
Contributor

Cheney-W commented Dec 2, 2024

https://www.nasm.us/pub/nasm/releasebuilds/2.16.03/win64/ could get the nasm-2.16.03-win64.zip file.

@xavier2k6
Copy link
Contributor

xavier2k6 commented Dec 2, 2024 •
edited
Loading

https://www.nasm.us/pub/nasm/releasebuilds/2.16.03/win64/ could get the nasm-2.16.03-win64.zip file.

Correct but when nasm.us goes down/intermittent issues like in the past hence why mirrors were added, these mirrors/alternatives will then not be able to provide the requested nasm version that doesn't exist/isn't hosted.

@xavier2k6
Copy link
Contributor

Possible solution:
Remove the mirror host -> https://gstreamer.freedesktop.org/src/mirror/ & update the asset (with 2.16.03) hosted -> https://vcpkg.github.io/assets/nasm/

@creeksuen
[nasm] Update to 2.16.03
Loading
Loading status checks…
18f6bbb
@creeksuen
Copy link
Contributor Author

Possible solution: Remove the mirror host -> https://gstreamer.freedesktop.org/src/mirror/ & update the asset (with 2.16.03) hosted -> https://vcpkg.github.io/assets/nasm/
I have removed the mirror https://gstreamer.freedesktop.org/src/mirror/. Could you please advise on how to update the asset version of https://vcpkg.github.io/assets/nasm/ to 2.16.03?

@BillyONeal
Copy link
Member

@JavierMatosD can you add this file to the website?

BillyONeal added a commit to BillyONeal/vcpkg.github.io that referenced this pull request Dec 3, 2024
@BillyONeal
Add new NASM from microsoft/vcpkg#42432
3f14acf
@BillyONeal BillyONeal merged commit a02df3d into microsoft:master Dec 4, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

JavierMatosD pushed a commit to vcpkg/vcpkg.github.io that referenced this pull request Dec 4, 2024
@BillyONeal
Add new NASM from microsoft/vcpkg#42432 (#241)
5e28ca9 
* Add new NASM from microsoft/vcpkg#42432

* Add asset link for nasm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W

Assignees

@Cheney-W Cheney-W

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@creeksuen @xavier2k6 @Cheney-W @BillyONeal