Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node-specific export condition for ESM entrypoint that re-exports CJS #201

Merged
merged 2 commits into from May 1, 2023
Merged

Add Node-specific export condition for ESM entrypoint that re-exports CJS #201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0a67d9
Add Node-specific export condition for ESM entrypoint that re-exports…
andrewbranch May 1, 2023
897f11e
Ensure tslib.es6.js is typed
andrewbranch May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 11 additions & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -28,8 +28,17 @@
"sideEffects": false,
"exports": {
".": {
"module": "./tslib.es6.js",
"import": "./modules/index.js",
"module": {
"types": "./tslib.d.ts",
"default": "./tslib.es6.js"
},
"import": {
"node": "./modules/index.js",
"default": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is relying on microsoft/TypeScript#50762 to resolve types for the node import case, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s going to use #200

"types": "./tslib.d.ts",
"default": "./tslib.es6.js"
}
},
"default": "./tslib.js"
},
"./*": "./*",
Expand Down