Feat: allow cooperative timeout #3314
Merged
+844
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
…rties/launchSettings.json
Evangelink
commented
Jul 23, 2024
src/TestFramework/TestFramework/Attributes/TestMethod/TimeoutAttribute.cs
Show resolved
Hide resolved
nohwnd
reviewed
Jul 24, 2024
src/TestFramework/TestFramework/Attributes/TestMethod/TimeoutAttribute.cs
Outdated
Show resolved
Hide resolved
…ttribute.cs Co-authored-by: Jakub Jareš <me@jakubjares.com>
…ttribute.cs Co-authored-by: Jakub Jareš <me@jakubjares.com>
nohwnd
previously approved these changes
Jul 24, 2024
# Conflicts: # test/IntegrationTests/MSTest.Acceptance.IntegrationTests/InitializeAndCleanupTimeoutTests.cs # test/IntegrationTests/MSTest.Acceptance.IntegrationTests/STATestClassTests.cs # test/IntegrationTests/MSTest.Acceptance.IntegrationTests/STATestMethodTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the timeout will create a "thread" that will observe the execution of the step (fixture or test method) for a given time (timeout value) and will stop observing after that. This means that we are producing dangling tasks where code continues to execute and possibly mutate state when we move to the next step which can have many unwanted consequences.
With this PR, we introduce a virtuous mode that ressemble what user has to do when implementing cooperative cancellation in their production code.
/!\ It's important to note that when opting-in to this mode, if the method (fixture or test) is ignoring the token then the method will continue.
Fixes #2432