Fix support of winui for net6+ #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When introducing net8.0 and net9.0, we broke the referencing of the specifically built dll. Instead of referencing the same dll multiple times, I have decided to update the target to copy the net6 one. I will investigate separately the complexity and benefit of multi-targeting the netX-windowsY entries.
|
Known flaky test, I'll force merge. |
|
Confirmed @Evangelink , manually copying the WinUI directories from net-6.0 to net-8.0 eliminates the build errors and the tests run as before. |
Evangelink
added a commit
that referenced
this pull request
Feb 6, 2024
When introducing net8.0 and net9.0, we broke the referencing of the specifically built dll. Instead of referencing the same dll multiple times, I have decided to update the target to copy the net6 one. I will investigate separately the complexity and benefit of multi-targeting the netX-windowsY entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introducing net8.0 and net9.0, we broke the referencing of the specifically built dll. Instead of referencing the same dll multiple times, I have decided to update the target to copy the net6 one.
I will investigate separately the complexity and benefit of multi-targeting the netX-windowsY entries.
Fixes #2188
@abdes you should be able to modify the locally extracted NuGet package to apply the same change if you want to do some manual double checking. It works for me on the project shared in the linked issue.