Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ValueTask return type #2208

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Add support for ValueTask return type #2208

merged 3 commits into from
Jan 31, 2024

Conversation

Evangelink
Copy link
Member

Assembly/Class/Test Initialize/Cleanup and TestMethods now support ValueTask as return type.

Fixes #2106

@Evangelink
Add support for ValueTask return type
6f284a8 
Assembly/Class/Test Initialize/Cleanup and TestMethods now support
`ValueTask` as return type.
@Evangelink Evangelink enabled auto-merge (squash) January 30, 2024 20:16
cvpoienaru
cvpoienaru previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@cvpoienaru cvpoienaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Evangelink
Copy link
Member Author

I just realized that I need to update the analyzers to support htis case too.

@Evangelink Evangelink merged commit 9ced4cb into microsoft:main Jan 31, 2024
6 checks passed
@Evangelink Evangelink deleted the valuetask-support branch January 31, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvpoienaru cvpoienaru cvpoienaru left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow ValueTask as return type for test methods and others
2 participants
@Evangelink @cvpoienaru