Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #2121 DataTestMethodAttribute is missing a constructor #2125

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

HannoZ
Copy link
Contributor

@HannoZ HannoZ commented Jan 18, 2024

A fix for issue #2121 DataTestMethodAttribute doesn't have a constructor to set display name

I added the constructor and extended the TypeEnumerator logic to get the DisplayName for DataTestMethodAttribute (only if no regular TestMethodAttribute was found)
Renamed an existing unit test for TestMethodAttribute and added a new test for DataTestMethodAttribute that verifies that the DisplayName is set.

@HannoZ
Copy link
Contributor Author

HannoZ commented Jan 18, 2024

@microsoft-github-policy-service agree company="Nextens"

@Evangelink
Copy link
Member

Thanks for the contribution @HannoZ :shipit:

@Evangelink Evangelink merged commit c969b47 into microsoft:main Jan 19, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants