-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Ubuntu 24.04 #30826
base: main
Are you sure you want to change the base?
feat: support Ubuntu 24.04 #30826
Conversation
This comment has been minimized.
This comment has been minimized.
4562e7e
to
1d1be4b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a711c28
to
0da438a
Compare
0da438a
to
be95de6
Compare
This comment has been minimized.
This comment has been minimized.
``` | ||
|
||
#### Crawling and scraping | ||
|
||
On untrusted websites, it's recommended to use a separate user for launching the browsers in combination with the seccomp profile. Inside the container or if you are using the Docker image as a base image you have to use `adduser` for it. | ||
|
||
```bash js | ||
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright:v%%VERSION%%-jammy /bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's wait until first patch release of 24.04?
@@ -131,7 +131,7 @@ By default browsers launched with Playwright run headless, meaning no browser UI | |||
- Java 8 or higher. | |||
- Windows 10+, Windows Server 2016+ or Windows Subsystem for Linux (WSL). | |||
- MacOS 12 Monterey, MacOS 13 Ventura, or MacOS 14 Sonoma. | |||
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04. | |||
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04, Ubuntu 24.04 - (x86-64 or arm64 architecture). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, on x86-64 and arm64 architecture.
is more clear that it relates to all versions rather than just u24.
@@ -129,7 +129,7 @@ npx playwright --version | |||
- Node.js 18+ | |||
- Windows 10+, Windows Server 2016+ or Windows Subsystem for Linux (WSL). | |||
- MacOS 12 Monterey, MacOS 13 Ventura, or MacOS 14 Sonoma. | |||
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04, with x86-64 or arm64 architecture. | |||
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04, Ubuntu 24.04 - (x86-64 or arm64 architecture). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -102,7 +102,7 @@ pip install pytest-playwright playwright -U | |||
- Python 3.8 or higher. | |||
- Windows 10+, Windows Server 2016+ or Windows Subsystem for Linux (WSL). | |||
- MacOS 12 Monterey, MacOS 13 Ventura, or MacOS 14 Sonoma. | |||
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04. | |||
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04, Ubuntu 24.04 - (x86-64 or arm64 architecture). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
@@ -450,6 +450,218 @@ export const deps: any = { | |||
'libevent-2.1.so.7': 'libevent-2.1-7', | |||
}, | |||
}, | |||
|
|||
'ubuntu24.04-x64': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does our deps generator script work or it's just a copy of 22?
Test results for "tests 1"27008 passed, 610 skipped Merge workflow run. |
Test results for "tests 2"4 fatal errors, not part of any test 47 flaky192451 passed, 8482 skipped, 2619 did not run Merge workflow run. |
#30368