Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsload): fix tsconfig inheritance resolution #29766

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

pavelfeldman
Copy link
Member

Fixes #29731

@@ -101,7 +101,8 @@ function resolveConfigFile(baseConfigFile: string, referencedConfigFile: string)
referencedConfigFile += '.json';
const currentDir = path.dirname(baseConfigFile);
let resolvedConfigFile = path.resolve(currentDir, referencedConfigFile);
if (referencedConfigFile.indexOf('/') !== -1 && referencedConfigFile.indexOf('.') !== -1 && !fs.existsSync(referencedConfigFile))
// TODO: I don't see how this makes sense, delete in the next minor release.
if (referencedConfigFile.includes('/') && referencedConfigFile.includes('.') && !fs.existsSync(resolvedConfigFile))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where the bug was - referencedConfigFile vs resolvedConfigFile. We should delete this code altogether imo

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Test results for "tests 1"

5 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:188:5 › should watch component
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

26643 passed, 614 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit ff16d79 into microsoft:main Mar 1, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression]: 1.42.0 breaks some @import statements
2 participants