Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: point to the right cli program export #29715

Merged
merged 1 commit into from
Feb 28, 2024
+9 −3
Merged

fix: point to the right cli program export #29715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/playwright-chromium/cli.js
View file
Open in desktop
Expand Up @@ -15,5 +15,5 @@
* limitations under the License.
*/

const { program } = require('playwright-core/lib/program');
const { program } = require('playwright-core/lib/cli/program');
program.parse(process.argv);
2 changes: 1 addition & 1 deletion packages/playwright-firefox/cli.js
View file
Open in desktop
Expand Up @@ -15,5 +15,5 @@
* limitations under the License.
*/

const { program } = require('playwright-core/lib/program');
const { program } = require('playwright-core/lib/cli/program');
program.parse(process.argv);
2 changes: 1 addition & 1 deletion packages/playwright-webkit/cli.js
View file
Open in desktop
Expand Up @@ -15,5 +15,5 @@
* limitations under the License.
*/

const { program } = require('playwright-core/lib/program');
const { program } = require('playwright-core/lib/cli/program');
program.parse(process.argv);
6 changes: 6 additions & 0 deletions tests/installation/playwright-cli-install-should-work.spec.ts
View file
Open in desktop
Expand Up @@ -89,3 +89,9 @@ test('subsequent installs works', async ({ exec }) => {
// of UnhandledPromiseRejection.
await exec('node --unhandled-rejections=strict', path.join('node_modules', '@playwright', 'browser-chromium', 'install.js'));
});

test('install playwright-chromium should work', async ({ exec, installedSoftwareOnDisk }) => {
await exec('npm i playwright-chromium');
await exec('npx playwright install chromium');
await exec('node sanity.js playwright-chromium chromium');
});