fix(tsload): fix tsconfig inheritance resolution #29766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
commented
Mar 1, 2024
| @@ -101,7 +101,8 @@ function resolveConfigFile(baseConfigFile: string, referencedConfigFile: string) | |||
| referencedConfigFile += '.json'; | |||
| const currentDir = path.dirname(baseConfigFile); | |||
| let resolvedConfigFile = path.resolve(currentDir, referencedConfigFile); | |||
| if (referencedConfigFile.indexOf('/') !== -1 && referencedConfigFile.indexOf('.') !== -1 && !fs.existsSync(referencedConfigFile)) | |||
| // TODO: I don't see how this makes sense, delete in the next minor release. | |||
| if (referencedConfigFile.includes('/') && referencedConfigFile.includes('.') && !fs.existsSync(resolvedConfigFile)) | |||
There was a problem hiding this comment.
This is where the bug was - referencedConfigFile vs resolvedConfigFile. We should delete this code altogether imo
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Mar 1, 2024
Test results for "tests 1"5 flaky26643 passed, 614 skipped Merge workflow run. |
pavelfeldman
added a commit
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29731