Add additional registry values to uVM via annotation #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow callers to specify additional registry values in the WCOW OS via the `io.microsoft.virtualmachine.wcow.additional-reg-keys` annotation. The intent is to test and validate bug fixes or debug uVM behavior (eg, via setting values in `SYSTEM\CurrentControlSet\Services\wcifs`, `SYSTEM\CurrentControlSet\Policies\Microsoft\FeatureManagement\Overrides\*`) without requiring a new package. The annotation is under `internal/annotations`, since it is not suitable for end users to rely on. Additionally, limit the settable registry keys to prevent it being used (abused) as a catch all mechanism to arbitrarily modify uVM behavior. Additionally, add [RegistryValueType](https://learn.microsoft.com/en-us/virtualization/api/hcs/schemareference#RegistryValueType) and [RegistryHive](https://learn.microsoft.com/en-us/virtualization/api/hcs/schemareference#RegistryHive) enum types for HCS v2 schema. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
wcow-add-regs
branch
from
2324fa3
to
6a74366
Compare
kiashok
approved these changes
Nov 9, 2023
ambarve
reviewed
Nov 9, 2023
ambarve
reviewed
Nov 9, 2023
anmaxvl
reviewed
Nov 9, 2023
anmaxvl
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow callers to specify additional registry values in the WCOW OS via the
io.microsoft.virtualmachine.wcow.additional-reg-keysannotation.The intent is to test and validate bug fixes or debug uVM behavior (eg, via setting values in
SYSTEM\CurrentControlSet\Services\wcifs,SYSTEM\CurrentControlSet\Policies\Microsoft\FeatureManagement\Overrides\*) without requiring a new package.The annotation is under
internal/annotations, since it is not suitable for end users to rely on.Additionally, limit the settable registry keys to prevent it being used (abused) as a catch all mechanism to arbitrarily modify uVM behavior.
Additionally, add
RegistryValueType and
RegistryHive enum types for HCS v2 schema.