[release/0.11] make sure to close files in dmverity-vhd tool (#1770) #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we're not closing output VHD files and read closers when creating layer VHDs with dmverity-vhd tool. Refactor error wrapping. Signed-off-by: Maksim An <maksiman@microsoft.com> (cherry picked from commit 567f6bd)
helsaawy
approved these changes
Oct 23, 2023
opened another PR to address comments: #1948 I'll cherry pick that one here as well. |
i totally missed that this was a merge into release/0.11 and not main lol |
Use `errors` package instead of the `github.com/pkg/errors`. `createVHD` accepts layer number to avoid calling `layer.DiffID()` twice. Signed-off-by: Maksim An <maksiman@microsoft.com> (cherry picked from commit a3be979)
|
Nit: could you please add [release/0.11] to the title? :) |
kiashok
approved these changes
Oct 27, 2023
anmaxvl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update release branch to include some fixes for
dmverity-vhdtool: