Add handling of ENTRYPOINT and CMD when "command" is not in policy #1304
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me |
anmaxvl
force-pushed
the
policy-image-entrypoint
branch
from
de66cd1 to
a4dd146
Compare
Container images may contain ENTRYPOINT and CMD directives and in the case when "command" is missing in policy config, that information needs to be inferred from the image itself. Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
policy-image-entrypoint
branch
from
a4dd146 to
7f3af60
Compare
jterry75
reviewed
Mar 16, 2022
dcantah
approved these changes
May 4, 2022
helsaawy
approved these changes
May 6, 2022
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…osoft#1304) Container images may contain ENTRYPOINT and CMD directives and in the case when "command" is missing in policy config, that information needs to be inferred from the image itself. Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container images may contain ENTRYPOINT and CMD directives and in
the case when "command" is missing in policy config, that information
needs to be inferred from the image itself.
Signed-off-by: Maksim An maksiman@microsoft.com