-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip flaky TestPseudoConsolePowershell #1285
Conversation
@katiewasnothere Can you look at this?
|
@dcantah rerunning the CI. That test is a bit flaky as well but only seems to hit every once in a while. |
@katiewasnothere Is it just the hcn network isn't getting cleaned up from another test? I was going to say maybe another test that creates it is running at the same time but we don't run our tests in parallel afaik |
@dcantah Talking to you offline about this. The test likely needs some additional debugging to determine the root cause. Could you add a "TODO" comment to fix the test? |
This test is fairly flaky on the Github CI but seems to run fine locally (maybe pure luck). Skip this for now to let contributions continue without a hitch and until we can replace this with a better suited test shortly. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
5fedd8f
to
1cdd3da
Compare
@katiewasnothere Sorry never replied even though I added the comment. Done! |
LGTM |
This test is fairly flaky on the Github CI but seems to run fine locally (maybe pure luck). Skip this for now to let contributions continue without a hitch and until we can replace this with a better suited test shortly. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
This test is fairly flaky on the Github CI but seems to run fine locally (maybe pure
luck). Skip this for now to let contributions continue without a hitch and until we
can replace this with a better suited test shortly.