Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test_ExtendedTask_ProcessorInfo CRI test #1283

Merged

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Jan 20, 2022

Test_ExtendedTask_ProcessorInfo had a minor bug, when the
processor info request would return an error and the error was
expected. The test would still proceed to check the processor
count from the response in whicn case the response is nil and
the check results in nil point dereference.

Signed-off-by: Maksim An maksiman@microsoft.com

Test_ExtendedTask_ProcessorInfo had a minor bug, when the
processor info request would return an error and the error was
expected. The test would still proceed to check the processor
count from the response in whicn case the response is nil and
the check results in nil point dereference.

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl requested a review from a team as a code owner January 20, 2022 17:53
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you for fixing this :)

@katiewasnothere katiewasnothere merged commit 92d8d36 into microsoft:master Jan 20, 2022
@anmaxvl anmaxvl deleted the fix-extended-process-info-test branch January 20, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants