Add logging to layer retry code path #1281
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a small log to the code path that handles retrying layer setup if we encountered a set of known error codes that we'd observed on ws2019. This is mostly just so we can tell how often we're actually hitting this and see which error is most prevalent. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
add-retrylayer-log
branch
from
e2d9fd0 to
2c7d2d7
Compare
We have a timeout defined in the golangci.yml file but it doesn't get honored as the commandline flags have higher priority. This change removes the --timeout specified for args so the timeout from the config will be used. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
helsaawy
approved these changes
Jan 19, 2022
anmaxvl
approved these changes
Jan 20, 2022
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Add logging to layer retry code path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a small log to the code path that handles retrying layer setup if we encountered a set of known error codes that we'd observed on ws2019. This is mostly just so we can tell how often we're actually hitting this and see which error is most prevalent.
This additionally contains a commit to remove the --timeout flag passed for our golangci runs. The command line flags have higher priority than the config file so our timeout defined there wasn't being honored.