Rename conpty.New to conpty.Create #1254
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
conpty.ConPTY is also kind of redundant.. Perhaps a different name for the package or a different name for the struct is in order. |
This change renames conpty.New, the method used to create a new ConPTY object, to Create instead. Mostly preference and to stay in line with what we'd named the method for creating a job object. The windows API used to create the pty is named 'CreatePseudoConsole' so to me it makes more sense. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
rename-conpty-new
branch
from
c914313 to
f30a2d5
Compare
anmaxvl
approved these changes
Dec 24, 2021
|
|
But also, if we are switching to |
That sounds pretty good to me and is probably better than the 'conpty.PseudoConsole' idea that was in my head haha |
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
Jan 4, 2022
This change renames conpty.New, the method used to create a new ConPTY object, to Create instead. Mostly preference and to stay in line with what we'd named the method for creating a job object. The windows API used to create the pty is named 'CreatePseudoConsole' so to me it makes more sense. Signed-off-by: Daniel Canter <dcanter@microsoft.com> (cherry picked from commit 0124eb3) Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
Jan 4, 2022
This change renames conpty.New, the method used to create a new ConPTY object, to Create instead. Mostly preference and to stay in line with what we'd named the method for creating a job object. The windows API used to create the pty is named 'CreatePseudoConsole' so to me it makes more sense. Signed-off-by: Daniel Canter <dcanter@microsoft.com> (cherry picked from commit 0124eb3) Signed-off-by: Daniel Canter <dcanter@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
This change renames conpty.New, the method used to create a new ConPTY object, to Create instead. Mostly preference and to stay in line with what we'd named the method for creating a job object. The windows API used to create the pty is named 'CreatePseudoConsole' so to me it makes more sense. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames conpty.New, the method used to create a new ConPTY object, to Create instead. Mostly preference and to stay in line with what we'd named the method for creating a job object. The windows API used to create the pty is 'CreatePseudoConsole' so to me it makes more sense and would be more familiar to folks if this was ever moved out of /internal for outside use.