-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaffold new dev docs #30483
Scaffold new dev docs #30483
Conversation
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 609 | 609 | 5000 | |
Button | mount | 278 | 280 | 5000 | |
Field | mount | 1046 | 1076 | 5000 | |
FluentProvider | mount | 654 | 679 | 5000 | |
FluentProviderWithTheme | mount | 79 | 81 | 10 | |
FluentProviderWithTheme | virtual-rerender | 61 | 53 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 61 | 10 | |
MakeStyles | mount | 844 | 852 | 50000 | |
Persona | mount | 1672 | 1657 | 5000 | |
SpinButton | mount | 1328 | 1360 | 5000 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
🕵 fluentuiv8 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AttachmentMinimalPerf.default | 91 | 79 | 1.15:1 |
ImageMinimalPerf.default | 236 | 212 | 1.11:1 |
SkeletonMinimalPerf.default | 202 | 184 | 1.1:1 |
TreeWith60ListItems.default | 90 | 82 | 1.1:1 |
AvatarMinimalPerf.default | 113 | 105 | 1.08:1 |
DropdownManyItemsPerf.default | 415 | 384 | 1.08:1 |
AnimationMinimalPerf.default | 298 | 279 | 1.07:1 |
ButtonMinimalPerf.default | 88 | 83 | 1.06:1 |
LayoutMinimalPerf.default | 201 | 190 | 1.06:1 |
ListMinimalPerf.default | 320 | 301 | 1.06:1 |
BoxMinimalPerf.default | 192 | 183 | 1.05:1 |
ChatDuplicateMessagesPerf.default | 159 | 151 | 1.05:1 |
ChatWithPopoverPerf.default | 186 | 177 | 1.05:1 |
HeaderSlotsPerf.default | 476 | 452 | 1.05:1 |
LabelMinimalPerf.default | 221 | 211 | 1.05:1 |
ChatMinimalPerf.default | 449 | 431 | 1.04:1 |
ListWith60ListItems.default | 375 | 359 | 1.04:1 |
StatusMinimalPerf.default | 400 | 384 | 1.04:1 |
ButtonSlotsPerf.default | 322 | 312 | 1.03:1 |
InputMinimalPerf.default | 536 | 519 | 1.03:1 |
MenuMinimalPerf.default | 515 | 499 | 1.03:1 |
ProviderMergeThemesPerf.default | 664 | 647 | 1.03:1 |
ReactionMinimalPerf.default | 219 | 213 | 1.03:1 |
SliderMinimalPerf.default | 753 | 728 | 1.03:1 |
SplitButtonMinimalPerf.default | 2246 | 2178 | 1.03:1 |
CustomToolbarPrototype.default | 1495 | 1458 | 1.03:1 |
ToolbarMinimalPerf.default | 553 | 537 | 1.03:1 |
EmbedMinimalPerf.default | 1896 | 1861 | 1.02:1 |
HeaderMinimalPerf.default | 210 | 206 | 1.02:1 |
ListNestedPerf.default | 327 | 322 | 1.02:1 |
MenuButtonMinimalPerf.default | 955 | 940 | 1.02:1 |
TreeMinimalPerf.default | 498 | 486 | 1.02:1 |
VideoMinimalPerf.default | 454 | 443 | 1.02:1 |
AccordionMinimalPerf.default | 79 | 78 | 1.01:1 |
GridMinimalPerf.default | 187 | 186 | 1.01:1 |
LoaderMinimalPerf.default | 189 | 188 | 1.01:1 |
RosterPerf.default | 1538 | 1522 | 1.01:1 |
ProviderMinimalPerf.default | 202 | 200 | 1.01:1 |
TooltipMinimalPerf.default | 1267 | 1259 | 1.01:1 |
AttachmentSlotsPerf.default | 625 | 622 | 1:1 |
ButtonOverridesMissPerf.default | 647 | 646 | 1:1 |
CardMinimalPerf.default | 305 | 305 | 1:1 |
CheckboxMinimalPerf.default | 1114 | 1116 | 1:1 |
PopupMinimalPerf.default | 349 | 348 | 1:1 |
PortalMinimalPerf.default | 80 | 80 | 1:1 |
RadioGroupMinimalPerf.default | 261 | 261 | 1:1 |
TableMinimalPerf.default | 223 | 224 | 1:1 |
TextAreaMinimalPerf.default | 286 | 285 | 1:1 |
DividerMinimalPerf.default | 198 | 201 | 0.99:1 |
DropdownMinimalPerf.default | 1399 | 1415 | 0.99:1 |
FlexMinimalPerf.default | 152 | 153 | 0.99:1 |
FormMinimalPerf.default | 225 | 227 | 0.99:1 |
ItemLayoutMinimalPerf.default | 690 | 700 | 0.99:1 |
IconMinimalPerf.default | 387 | 390 | 0.99:1 |
TableManyItemsPerf.default | 1096 | 1107 | 0.99:1 |
DatepickerMinimalPerf.default | 3477 | 3566 | 0.98:1 |
DialogMinimalPerf.default | 433 | 443 | 0.98:1 |
RefMinimalPerf.default | 112 | 114 | 0.98:1 |
CarouselMinimalPerf.default | 254 | 263 | 0.97:1 |
ListCommonPerf.default | 400 | 411 | 0.97:1 |
TextMinimalPerf.default | 190 | 195 | 0.97:1 |
AlertMinimalPerf.default | 155 | 163 | 0.95:1 |
SegmentMinimalPerf.default | 187 | 196 | 0.95:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size reportUnchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 623 | 624 | 5000 | |
Breadcrumb | mount | 1697 | 1681 | 1000 | |
Checkbox | mount | 1693 | 1683 | 5000 | |
CheckboxBase | mount | 1487 | 1453 | 5000 | |
ChoiceGroup | mount | 2876 | 2879 | 5000 | |
ComboBox | mount | 644 | 635 | 1000 | |
CommandBar | mount | 6260 | 6327 | 1000 | |
ContextualMenu | mount | 13800 | 13763 | 1000 | |
DefaultButton | mount | 747 | 726 | 5000 | |
DetailsRow | mount | 2217 | 2162 | 5000 | |
DetailsRowFast | mount | 2167 | 2223 | 5000 | |
DetailsRowNoStyles | mount | 1975 | 1991 | 5000 | |
Dialog | mount | 2779 | 2645 | 1000 | |
DocumentCardTitle | mount | 228 | 234 | 1000 | |
Dropdown | mount | 1984 | 1987 | 5000 | |
FocusTrapZone | mount | 1141 | 1160 | 5000 | |
FocusZone | mount | 1071 | 1078 | 5000 | |
GroupedList | mount | 37574 | 41586 | 2 | |
GroupedList | virtual-rerender | 19958 | 19910 | 2 | |
GroupedList | virtual-rerender-with-unmount | 50763 | 50724 | 2 | |
GroupedListV2 | mount | 228 | 217 | 2 | |
GroupedListV2 | virtual-rerender | 216 | 220 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 228 | 223 | 2 | |
IconButton | mount | 1067 | 1069 | 5000 | |
Label | mount | 328 | 340 | 5000 | |
Layer | mount | 2760 | 2782 | 5000 | |
Link | mount | 387 | 390 | 5000 | |
MenuButton | mount | 939 | 940 | 5000 | |
MessageBar | mount | 21552 | 21571 | 5000 | |
Nav | mount | 1893 | 1981 | 1000 | |
OverflowSet | mount | 807 | 775 | 5000 | |
Panel | mount | 2063 | 1759 | 1000 | |
Persona | mount | 739 | 736 | 1000 | |
Pivot | mount | 868 | 857 | 1000 | |
PrimaryButton | mount | 838 | 835 | 5000 | |
Rating | mount | 4604 | 4558 | 5000 | |
SearchBox | mount | 901 | 905 | 5000 | |
Shimmer | mount | 1902 | 1831 | 5000 | |
Slider | mount | 1321 | 1334 | 5000 | |
SpinButton | mount | 2951 | 2831 | 5000 | |
Spinner | mount | 383 | 382 | 5000 | |
SplitButton | mount | 1825 | 1793 | 5000 | |
Stack | mount | 404 | 406 | 5000 | |
StackWithIntrinsicChildren | mount | 838 | 853 | 5000 | |
StackWithTextChildren | mount | 2589 | 2616 | 5000 | |
SwatchColorPicker | mount | 6191 | 6198 | 5000 | |
TagPicker | mount | 1455 | 1427 | 5000 | |
Text | mount | 373 | 369 | 5000 | |
TextField | mount | 933 | 942 | 5000 | |
ThemeProvider | mount | 844 | 828 | 5000 | |
ThemeProvider | virtual-rerender | 587 | 579 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1260 | 1289 | 5000 | |
Toggle | mount | 603 | 612 | 5000 | |
buttonNative | mount | 185 | 191 | 5000 |
I'm not sure if it should be part of this PR, but I'm leaving this comment so we can start to think about it. |
Is this PR ready to merge, or will there be work to complete the //TODO's? (If you could elaborate on the plan and details for the PR in the description that will help) I'm a little unsure about adding actual files with //TODO and assignees, should that be issues instead? If we have high confidence that we'll fast follow to fix these it's fine, but I'd hate for us to have empty md files with //TODO in them in the repo for an extended period of time (where as having an issue we haven't gotten around to yet is fine). Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, PR looks good!
e7cf0de
to
c1793a5
Compare
This PR is scaffolding our new documentation directory in the repo.
I will fast follow with individual PR's for each file, with the assigned reviewer giving me feedback.
Related issues:
Related RFC #30274
Related Epic #30642