Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo Site] Removes caching of markdown files for server demo app (Fixes #1770) #1822

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

oneolddev
Copy link
Contributor

@oneolddev oneolddev commented Apr 9, 2024

Pull Request

📖 Description

Fixes issue #1770 where markdown content of WhatsNew page would not render when navigated to the second time.

🎫 Issues

Size limits on JavaScript interop calls

An exception is thrown because the size of the markdown being sent back is exceeds the size limit.

👩‍💻 Reviewer Notes

I created two separate extensions to add the services required for the demo site, AddFluentUIDemoClientServices and AddFluentUIDemoServerServices, and removed AddFluentUIDemoServices.

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

Unverified

The signing certificate or its chain could not be verified.
@oneolddev
Copy link
Contributor Author

As for adding caching to the server side, if that is still desirable I can. I did some preliminary work based on Caching in .NET. The improvement was marginal and could be barely perceived from the user perspective.

It can still be added. Should I?

@vnbaaij
Copy link
Collaborator

vnbaaij commented Apr 9, 2024

As for adding caching to the server side, if that is still desirable I can. I did some preliminary work based on Caching in .NET. The improvement was marginal and could be barely perceived from the user perspective.

It can still be added. Should I?

No, think we can leave it out of the server variant. Normally we are ony running that locally anyway.

@oneolddev oneolddev marked this pull request as ready for review April 9, 2024 18:54

Unverified

The signing certificate or its chain could not be verified.
@oneolddev oneolddev changed the title [Demo Site] Removes caching of markdown files for server demo app [Demo Site] Removes caching of markdown files for server demo app (Fixes #1770) Apr 10, 2024
@vnbaaij vnbaaij enabled auto-merge (squash) April 10, 2024 05:41

Unverified

The signing certificate or its chain could not be verified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants