Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css files improvements #1807

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Css files improvements #1807

merged 1 commit into from
Apr 7, 2024

Conversation

zandiarash
Copy link
Contributor

@zandiarash zandiarash commented Apr 7, 2024

The issue #1806 will be solved
I've also auto indented CSS files
And I removed the empty CSS rule in site.css

 nav ul li {
                }

Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for you contribution!

Please undo the indenting changes. We use this to make clear how the different elements relate to each other (ie .siteheader.links is a 'child' of .siteheader). Visual Studio also auto-formats to this .

Also, please undo the changes to the test/TemplateValidation files. We generate these projects with a script and validate then that the right files and content gets created.

Focus only on the changes to fix the issue. The rest can be discussed and, if agreed upon, be done in a separate PR.

@zandiarash zandiarash reopened this Apr 7, 2024
@zandiarash
Copy link
Contributor Author

zandiarash commented Apr 7, 2024

Hi,

Thanks for you contribution!

Please undo the indenting changes. We use this to make clear how the different elements relate to each other (ie .siteheader.links is a 'child' of .siteheader). Visual Studio also auto-formats to this .

Also, please undo the changes to the test/TemplateValidation files. We generate these projects with a script and validate then that the right files and content gets created.

Focus only on the changes to fix the issue. The rest can be discussed and, if agreed upon, be done in a separate PR.

Thank you for reviewing my pull request.
I understand your feedback regarding the indenting changes and the modifications to the test/TemplateValidation files. I reverted those changes accordingly.
Now I've focused solely on addressing the issue at hand and leave the formatting and made the necessary adjustments promptly and resubmit the pull request.

@zandiarash zandiarash requested a review from vnbaaij April 7, 2024 10:15
@vnbaaij vnbaaij merged commit 60d78a2 into microsoft:dev Apr 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants