Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppBar] Add Count parameter and facilitate OnClick without navigation #1790

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Apr 3, 2024

Add a Count parameter to the FluentAppBarItem to make it possible to show a CounterBadge on an item (like yu have in Teams with number of unread chats, etc)

AppBarCount

Also, you can now use OnClick to trigger an action with doing a navigation step. Just supply a null value to the AppBarItem's Href. See the AppBarClick demo for examples.

#1786 needs to be merged before this

vnbaaij added 3 commits April 3, 2024 15:06
- Obsolete BottoPosition, ShowZero
- Update and add examples
- Update Tests
- Set Match when Href is null
@vnbaaij vnbaaij added the feature A new feature label Apr 3, 2024
@vnbaaij vnbaaij added this to the v4.6.1 milestone Apr 3, 2024
@vnbaaij vnbaaij requested a review from dvoituron April 3, 2024 18:46
Copy link
Collaborator

@dvoituron dvoituron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say :-) Just to block this PR before the CounterBadge PR.

There are no Unit Tests to change? Maybe a good time to add these tests :-)

vnbaaij added 2 commits April 4, 2024 12:23

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vnbaaij vnbaaij enabled auto-merge (squash) April 4, 2024 10:28
@vnbaaij vnbaaij merged commit a065395 into dev Apr 4, 2024
3 checks passed
@vnbaaij vnbaaij deleted the users/vnbaaij/appbar-upgrade branch April 4, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants