Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MarkdownSection] Fixes and enhancements #1751

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Conversation

oneolddev
Copy link
Contributor

Pull Request

📖 Description

Fix

  • Fixes edge case where the code block is preceded with markdig generic attributes in source markdown document. Pipeline sets OutputAttributesOnPre to true.

Enhancements

  • adds an options class for renderer
  • addtional attributes are specified in markdig generic attributes format for addtional flexibility

Miscellaneous

  • corrects minor format issue in DesignTokens.md

🎫 Issues

  • Edge case not handled.

👩‍💻 Reviewer Notes

I made the default indentation to about 4 charcters. Subjectively thinks it looks better.

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validate Unit Tests for an existing component

⏭ Next Steps

Sorry, something went wrong.

oneolddev and others added 5 commits March 27, 2024 10:43

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
pass additional attributes as markdig GenericAttributes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@vnbaaij vnbaaij merged commit c651050 into microsoft:dev Mar 27, 2024
1 check passed
@oneolddev oneolddev deleted the markdownfix2 branch March 27, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants