Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Avoid padding on loading spinner when no text is shown #1714

Merged
merged 2 commits into from
Mar 18, 2024
Merged

[Button] Avoid padding on loading spinner when no text is shown #1714

merged 2 commits into from
Mar 18, 2024
+5 −5

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Mar 18, 2024

Fix #1707 by:

  • If no content, move ProgressRing to content part (like icon)
  • Make Progress ring a bit smaller then icon to not make button bigger in Loading state

@vnbaaij
- If no content, move ProgressRing to content part (like icon)
Loading
Loading status checks…
753a890 
- Make Progress ring a bit smaller then icon to not make button bigger in Loading state
@vnbaaij vnbaaij added the v3 label Mar 18, 2024
@vnbaaij vnbaaij added this to the vNext milestone Mar 18, 2024
@vnbaaij vnbaaij requested a review from dvoituron March 18, 2024 14:36
@vnbaaij vnbaaij enabled auto-merge (squash) March 18, 2024 19:17
@vnbaaij vnbaaij merged commit d67613b into dev Mar 18, 2024
4 checks passed
@vnbaaij vnbaaij deleted the users/vnbaaij/fix-issue-#1707 branch March 18, 2024 19:47
@vnbaaij vnbaaij changed the title Avoid padding loading icon on button when no text [Button] Avoid padding on loading spinner when no text is shown Mar 19, 2024
@vnbaaij vnbaaij mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoituron dvoituron

Assignees
No one assigned
Labels
v3
Projects
None yet
Milestone
v4.6.0
Development

Successfully merging this pull request may close these issues.

Avoid padding loading icon on button when no text
2 participants
@vnbaaij @dvoituron