Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pagination] Add Disabled parameter #1713

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

gitasaurus
Copy link
Contributor

feat(pagination): Adding in Disabled parameter to Pagination component

Adding in the ability to disable the pagination buttons on the Pagination control.

📖 Description

There are scenarios where a user can click the pagination navigation buttons faster than the navigation can complete (e.g. dynamically loading content). In these scenarios, it is useful to be able to disable the pagination navigation buttons until the navigation has completed.

This pull request adds to the Pagination component:

  • Disabled

🎫 Issues

  • None

👩‍💻 Reviewer Notes

  • None

📑 Test Plan

No pagination tests exist to update.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validate Unit Tests for an existing component

⏭ Next Steps

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vnbaaij vnbaaij requested a review from dvoituron March 18, 2024 16:09
@vnbaaij
Copy link
Collaborator

vnbaaij commented Mar 18, 2024

Looks good to me. @dvoituron, second pair of eyes please!

@dvoituron
Copy link
Collaborator

Seems good for me too

@vnbaaij vnbaaij merged commit a61562c into microsoft:dev Mar 18, 2024
2 checks passed
@vnbaaij vnbaaij changed the title feat(pagination): Adding in Disabled parameter to Pagination component [Pagination] Add Disabled parameter Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants