Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppBarItem] Add OnClick event callback #1698

Merged
merged 2 commits into from
Mar 15, 2024
Merged

[AppBarItem] Add OnClick event callback #1698

merged 2 commits into from
Mar 15, 2024
+96 −1

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Mar 15, 2024

And also add an example of using this:

image

Fix #1696

@vnbaaij
- Add AppBarItem OnClick
Loading
Loading status checks…
6fe2e3b 
- Add example
@vnbaaij vnbaaij added this to the vNext milestone Mar 15, 2024
@vnbaaij vnbaaij requested a review from dvoituron March 15, 2024 09:37
@vnbaaij vnbaaij enabled auto-merge (squash) March 15, 2024 09:38
dvoituron
dvoituron approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@dvoituron dvoituron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a new PR with some Unit Tests for this component?

@vnbaaij vnbaaij merged commit 4586f80 into dev Mar 15, 2024
4 checks passed
@vnbaaij vnbaaij deleted the users/vnbaaij/appbaritem-addclick branch March 15, 2024 09:50
@vnbaaij vnbaaij changed the title Add OnClick to AppBarItem [AppBarItem] Add OnClick event callback Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoituron dvoituron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.6.0
Development

Successfully merging this pull request may close these issues.

FluentAppBarItem Add Click Event
2 participants
@vnbaaij @dvoituron