Virtualization for FluentAutocomplete #1647
Merged
+134
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnbaaij
requested changes
Mar 7, 2024
dvoituron
previously requested changes
Mar 7, 2024
The MaximumOptionSearch can now be disabled by providing a negative number.
Using virtualization for Autocomplete greatly improves the initial rendering performance and rerendering performance if the search text is changed if many items/options are present.
auto-merge was automatically disabled
March 7, 2024 14:11
Head branch was pushed to by a user without write access
martinbu
force-pushed
the
feature/virtualize-autocomplete
branch
from
998e053 to
3c82f3b
Compare
vnbaaij
approved these changes
Mar 7, 2024
vnbaaij
dismissed
dvoituron’s stale review
I decided to not always use Virtualization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the virtualization feature for FluentAutocomplete discussed here #1638
For me the implementation works fine and greatly improves the initial rendering performance and the reactivity when a search is done on that list. The improvement can be checked by changing the Virtualize Parameter in the Autocomplete with Many Items Demo example.