Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer to Dotnet 8 #1630

Merged

Conversation

NickHirras
Copy link
Contributor

Pull Request

📖 Description

The devcontainer definition in this project was from Dotnet 6 and no longer usable. This PR updates to the new format and updates to Dotnet 8.

🎫 Issues

👩‍💻 Reviewer Notes

This is for the VSCode devcontainer feature.

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validate Unit Tests for an existing component

⏭ Next Steps

Sorry, something went wrong.

NickHirras and others added 2 commits March 4, 2024 15:25

Verified

This commit was signed with the committer’s verified signature.
RicePatrick Patrick Rice

Verified

This commit was signed with the committer’s verified signature.
RicePatrick Patrick Rice
@vnbaaij vnbaaij enabled auto-merge (squash) March 4, 2024 22:16
@vnbaaij vnbaaij merged commit 98ee6b7 into microsoft:dev Mar 4, 2024
2 checks passed
@NickHirras NickHirras deleted the nh-updates-devcontainer-to-dotnet-8 branch March 4, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants