-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a Filtered property and visual indicator to PropretyColumn in FluentDataGrid #1625
Adds a Filtered property and visual indicator to PropretyColumn in FluentDataGrid #1625
Conversation
Added same comment to the RFC. Does it make sense to use this red dot as the visual indicator, or should a new badge be created? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NickHirras I agree with Denis. Use the available Filter icons. There are sort of a badge as well but more clear then a red dot. |
@vnbaaij @dvoituron When trying to reference the FilterDismiss icon, it doesn't exist and getting a compiler error. Is this part of the Project Trimming / Generators? What do I need to do to make the FilterDismiss icon available in CoreIcons? |
In fact, all "internal" icons are located in the file |
…uentDataGrid (#1625) * adds filtered indicator * use a FilterDismiss icon instead of a badge * Removed comment about file being auto-generated, no longer applies --------- Co-authored-by: Vincent Baaij <vnbaaij@outlook.com>
Pull Request
📖 Description
Adds a Filtered boolean property to the PropertyColumn component of the FluentDataGrid. When set to true, it renders a visual indicator on the column header filter button, letting the user know this column is currently filtered.
The Demo for DataGrid Typical Usage has been updated to demonstrate this paramter.
See RFC
#1620
Recording.2024-03-03.200438.mp4
🎫 Issues
#1620
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps